Closed dellisd closed 5 years ago
Merging #63 into master will increase coverage by
0.13%
. The diff coverage is5.12%
.
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 12.89% 13.03% +0.13%
==========================================
Files 60 58 -2
Lines 659 660 +1
Branches 102 101 -1
==========================================
+ Hits 85 86 +1
Misses 548 548
Partials 26 26
Impacted Files | Coverage Δ | |
---|---|---|
...abagel/transpo/search/domain/UpdateQueryUseCase.kt | 100% <ø> (ø) |
|
...n/java/ca/llamabagel/transpo/map/ui/MapFragment.kt | 0% <ø> (ø) |
|
.../java/ca/llamabagel/transpo/map/ui/MapViewModel.kt | 0% <ø> (ø) |
|
...a/llamabagel/transpo/search/ui/CustomSearchView.kt | 0% <ø> (ø) |
|
...a/ca/llamabagel/transpo/trips/ui/TripsViewModel.kt | 0% <ø> (ø) |
|
...l/transpo/search/domain/GetSearchResultsUseCase.kt | 100% <ø> (ø) |
|
...ca/llamabagel/transpo/di/InjectionWorkerFactory.kt | 0% <ø> (ø) |
:arrow_up: |
...abagel/transpo/trips/ui/adapter/RouteViewHolder.kt | 0% <ø> (ø) |
|
...va/ca/llamabagel/transpo/trips/ui/TripsActivity.kt | 0% <ø> (ø) |
|
...ava/ca/llamabagel/transpo/home/ui/HomeViewModel.kt | 0% <ø> (ø) |
|
... and 38 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d35a571...77ececf. Read the comment docs.
Should trips ui package be broken further into fragments? Right now it's getting quite large.
This PR restructures the project and package structure of our code. Features are now top-level packages each with their respective data/domain/ui packages, as well as common shared layer-type packages
Checklist
./gradlew test connectedAndroidTest detekt
upstream/master