Llamabagel / transpo-android

Route 613 Android app (re-write)
MIT License
1 stars 2 forks source link

Repackage and restructure project #63

Closed dellisd closed 5 years ago

dellisd commented 5 years ago

This PR restructures the project and package structure of our code. Features are now top-level packages each with their respective data/domain/ui packages, as well as common shared layer-type packages

├── data        <-- shared data classes (data sources)
│   ├── api
│   └── db
├── di           <-- shared di classes (most dagger stuff)
├── home    <-- feature package
├── map     <-- feature package, etc.
│   └── ui
├── planner
├── saved
├── search 
│   ├── data          <-- feature-specific data classes (repositories)
│   ├── domain     <-- feature-specific domain classes (usecases)
│   └── ui              <-- feature ui classes (activities, fragments, viewmodels)
│       └── viewholders
├── transit         <-- "transit data" package
│   ├── data
│   └── workers
├── trips
│   ├── data
│   ├── domain
│   └── ui
│       └── adapter
├── ui            <-- shared ui classes
└── utils

Checklist

codecov[bot] commented 5 years ago

Codecov Report

Merging #63 into master will increase coverage by 0.13%. The diff coverage is 5.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   12.89%   13.03%   +0.13%     
==========================================
  Files          60       58       -2     
  Lines         659      660       +1     
  Branches      102      101       -1     
==========================================
+ Hits           85       86       +1     
  Misses        548      548              
  Partials       26       26
Impacted Files Coverage Δ
...abagel/transpo/search/domain/UpdateQueryUseCase.kt 100% <ø> (ø)
...n/java/ca/llamabagel/transpo/map/ui/MapFragment.kt 0% <ø> (ø)
.../java/ca/llamabagel/transpo/map/ui/MapViewModel.kt 0% <ø> (ø)
...a/llamabagel/transpo/search/ui/CustomSearchView.kt 0% <ø> (ø)
...a/ca/llamabagel/transpo/trips/ui/TripsViewModel.kt 0% <ø> (ø)
...l/transpo/search/domain/GetSearchResultsUseCase.kt 100% <ø> (ø)
...ca/llamabagel/transpo/di/InjectionWorkerFactory.kt 0% <ø> (ø) :arrow_up:
...abagel/transpo/trips/ui/adapter/RouteViewHolder.kt 0% <ø> (ø)
...va/ca/llamabagel/transpo/trips/ui/TripsActivity.kt 0% <ø> (ø)
...ava/ca/llamabagel/transpo/home/ui/HomeViewModel.kt 0% <ø> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d35a571...77ececf. Read the comment docs.

GustavoSanMartin commented 5 years ago

Should trips ui package be broken further into fragments? Right now it's getting quite large.