Llamabagel / transpo-android

Route 613 Android app (re-write)
MIT License
1 stars 2 forks source link

Rescoped trips-related viewmodels #65

Closed dellisd closed 5 years ago

dellisd commented 5 years ago

Changed design of Result class. Now has Loading TripsFragment works now

Checklist

codecov[bot] commented 5 years ago

Codecov Report

Merging #65 into master will increase coverage by 4.58%. The diff coverage is 45.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage    13.3%   17.88%   +4.58%     
==========================================
  Files          58       61       +3     
  Lines         684      710      +26     
  Branches      108      116       +8     
==========================================
+ Hits           91      127      +36     
+ Misses        565      541      -24     
- Partials       28       42      +14
Impacted Files Coverage Δ
...main/java/ca/llamabagel/transpo/utils/FlowUtils.kt 0% <0%> (ø)
...ava/ca/llamabagel/transpo/trips/ui/StopFragment.kt 0% <0%> (ø) :arrow_up:
...va/ca/llamabagel/transpo/trips/ui/TripsFragment.kt 0% <0%> (ø) :arrow_up:
...gel/transpo/trips/domain/GetNextBusTripsUseCase.kt 80% <100%> (-1.82%) :arrow_down:
...ain/java/ca/llamabagel/transpo/data/db/StopKeys.kt 100% <100%> (ø) :arrow_up:
...anspo/trips/domain/GetSelectedRouteTripsUseCase.kt 81.81% <100%> (+81.81%) :arrow_up:
...a/llamabagel/transpo/trips/data/TripsRepository.kt 55.55% <45.45%> (-2.51%) :arrow_down:
...a/ca/llamabagel/transpo/trips/ui/TripsViewModel.kt 36.36% <50%> (+36.36%) :arrow_up:
...src/main/java/ca/llamabagel/transpo/data/Result.kt 45.45% <55.55%> (+5.45%) :arrow_up:
...gel/transpo/trips/domain/GetRefreshStateUseCase.kt 60% <60%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9cfa6e5...387f400. Read the comment docs.

dellisd commented 5 years ago

There's no real point in fixing those.

GustavoSanMartin commented 5 years ago

There's no real point in fixing those.

I mean it's cleaner code...

dellisd commented 5 years ago

Barely though