search

Llamabagel / transpo-android

Route 613 Android app (re-write)
MIT License
1 stars 2 forks source link

Filter recent search results #71

Closed GustavoSanMartin closed 5 years ago

GustavoSanMartin commented 5 years ago

Checklist

Summary

Make search filters apply to recent search results

codecov[bot] commented 5 years ago

Codecov Report

Merging #71 into master will increase coverage by 1.39%. The diff coverage is 76.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   25.65%   27.04%   +1.39%     
==========================================
  Files          65       66       +1     
  Lines         846      854       +8     
  Branches      131      129       -2     
==========================================
+ Hits          217      231      +14     
- Misses        576      577       +1     
+ Partials       53       46       -7
Impacted Files Coverage Δ
.../ca/llamabagel/transpo/search/data/SearchFilter.kt 100% <ø> (ø) :arrow_up:
...abagel/transpo/search/domain/UpdateQueryUseCase.kt 100% <ø> (ø) :arrow_up:
...llamabagel/transpo/search/data/OttawaBoundaries.kt 0% <0%> (ø)
...java/ca/llamabagel/transpo/home/ui/MainActivity.kt 0% <0%> (ø) :arrow_up:
.../ca/llamabagel/transpo/di/TransitDatabaseModule.kt 70.58% <66.66%> (+3.92%) :arrow_up:
...agel/transpo/search/ui/viewholders/SearchResult.kt 71.73% <80%> (ø) :arrow_up:
...llamabagel/transpo/search/data/SearchRepository.kt 77.08% <88.46%> (+14.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 874b6b3...c0d154c. Read the comment docs.

dellisd commented 5 years ago

Would it make sense to name the implementations of SearchResult things like StopResult, PlaceResult, etc. instead of StopItem or PlaceItem, etc?

GustavoSanMartin commented 5 years ago

Would it make sense to name the implementations of SearchResult things like StopResult, PlaceResult, etc. instead of StopItem or PlaceItem, etc?

I think SearchResult.StopResult is a bit redundant