Llamabagel / transpo-android

Route 613 Android app (re-write)
MIT License
1 stars 2 forks source link

Add chip filter view #73

Closed GustavoSanMartin closed 5 years ago

GustavoSanMartin commented 5 years ago

Checklist

Summary

Kinda messy right now... duplicating Filter data classes but I wanted reusability (if we ever need to filter something other than search results). Definitely a better way of doing this. Also the on click listener is messy.. I need to pass a list of all the filters cause clicking on the x to clear all filters should only trigger the listener once (imo).

Screenshots

Recent Search Filtered
Screenshot_1563587984 Screenshot_1563587991 Screenshot_1563587996
Screenshot_1563587541 Screenshot_1563587547 Screenshot_1563587926
GustavoSanMartin commented 5 years ago

That's a good point.. I was mainly trying to match the YouTube Music app. device-2019-07-19-114705

codecov[bot] commented 5 years ago

Codecov Report

Merging #73 into master will increase coverage by 0.41%. The diff coverage is 39.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   27.25%   27.66%   +0.41%     
==========================================
  Files          65       66       +1     
  Lines         844      864      +20     
  Branches      128      128              
==========================================
+ Hits          230      239       +9     
- Misses        566      577      +11     
  Partials       48       48
Impacted Files Coverage Δ
.../ca/llamabagel/transpo/search/ui/SearchActivity.kt 0% <0%> (ø) :arrow_up:
.../ca/llamabagel/transpo/search/data/SearchFilter.kt 100% <100%> (ø) :arrow_up:
...l/transpo/search/domain/GetSearchResultsUseCase.kt 100% <100%> (ø) :arrow_up:
...ca/llamabagel/transpo/search/ui/SearchViewModel.kt 68.18% <100%> (ø) :arrow_up:
.../transpo/search/ui/viewholders/SearchFilterView.kt 5.55% <5.55%> (ø)
...llamabagel/transpo/search/data/SearchRepository.kt 81.25% <55.55%> (+1.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9dc1abe...9585000. Read the comment docs.