search

Llamabagel / transpo-android

Route 613 Android app (re-write)
MIT License
1 stars 2 forks source link

Implement initial Settings screen #77

Closed dellisd closed 5 years ago

dellisd commented 5 years ago

Restructured SharedPreferences in dagger graph Implemented abstraction around shared preferences Fix height of home fragment recycler view This PR also bundles in a minor fix for Live Updates. Old updates are now cleared properly and they are now ordered from latest to oldest.

Checklist

codecov[bot] commented 5 years ago

Codecov Report

Merging #77 into master will decrease coverage by 0.19%. The diff coverage is 5.55%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #77     +/-   ##
=========================================
- Coverage   29.52%   29.32%   -0.2%     
=========================================
  Files          70       72      +2     
  Lines         989      999     +10     
  Branches      142      142             
=========================================
+ Hits          292      293      +1     
- Misses        641      650      +9     
  Partials       56       56
Impacted Files Coverage Δ
...c/main/java/ca/llamabagel/transpo/di/DataModule.kt 0% <ø> (ø) :arrow_up:
...n/java/ca/llamabagel/transpo/TranspoApplication.kt 0% <ø> (ø) :arrow_up:
...a/llamabagel/transpo/trips/data/TripsRepository.kt 57.14% <0%> (+1.58%) :arrow_up:
...a/llamabagel/transpo/di/SharedPreferencesModule.kt 0% <0%> (ø) :arrow_up:
...java/ca/llamabagel/transpo/home/ui/HomeFragment.kt 0% <0%> (ø) :arrow_up:
...llamabagel/transpo/settings/ui/SettingsActivity.kt 0% <0%> (ø)
...ca/llamabagel/transpo/settings/data/AppSettings.kt 0% <0%> (ø)
.../ca/llamabagel/transpo/data/LocalMetadataSource.kt 0% <0%> (ø) :arrow_up:
...c/main/java/ca/llamabagel/transpo/di/CoreModule.kt 0% <0%> (ø) :arrow_up:
...mabagel/transpo/home/data/LiveUpdatesRepository.kt 66.66% <100%> (+0.81%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 02d07f9...0d86d54. Read the comment docs.