Max hit doesn't line up with new max hitsplat

LlemonDuck / dps-calculator

RuneLite plugin for calculating DPS based on gear+target, or providing recommendations for best equipment to wear.

BSD 2-Clause "Simplified" License

6 stars 14 forks source link

Max hit doesn't line up with new max hitsplat #78

Open ragsmaroon opened 2 years ago

ragsmaroon commented 2 years ago

Calculator says my max hit is 72, max hitsplat is 71 which lines up with the spreadsheet dps calc. If there's a way to generate a log of calculations, I'd be happy to do it. In the meantime here's all inputs and the output if that helps. If I had to guess, it's that changing the attack style to rapid doesn't change the attack speed stat provided by the plugin, which leads me to believe that the +3 style bonus from the accurate style is being applied, which lines up with the spreadsheet.

RuneLite_iXCT2TRu4o RuneLite_cF5ADei5X0 RuneLite_SwAou2AfHn RuneLite_0WwaDjz2EF RuneLite_gGcAv4VjJ9

Ribel38 commented 2 years ago

i have the same issue with DHL + salve seems like the max hit is rounded down before the next one is applied. From my testing the following equation seems to apply:

baseMaxHit = floor(0.5 + Eff.Str (Equi.Str +64)/640) MaxHit = floor(floor(baseMaxHitsalve_bonus)*dhl_or_dhc_bonus)

in the current code, there is no rounding down in between both bonuses

RonnyTommy548 commented 1 year ago

I found an issue with a max hit setup related to DHL and dragons as well. The plugin says that my max hit is 65, but in game it is 63. The google spreadsheets DPS calculator that everyone uses also agrees with the 63 max hit that I see in game.