tomb: death check for cursed phalanx detector

FiveNine commented 2 months ago

Issue:

Currently the "Detect Cursed Phalanx" feature only looks if you already have a cursed phalanx in inventory or a kitted fang. However, if you complete a 500 invocation raid even though you or a raid member had a death, it will still ask you to drop your kit before looting which is slightly annoying when you know it isnt a kit raid.

Solution:

This fix continuously checks for any player death utilizing the player orbs' varbits during the raid. If there was a single death, it will not ask you to drop your kit before looting a 500 invocation level raid.

FiveNine commented 2 months ago

For some reason the ctor to replace the Injected fields was making the build fail so I reverted that change for now.

LlemonDuck commented 2 months ago

Two things:

checking whether the raid room is null is potentially faulty due to some loading shenanigans where the game teleports you around a few times, but the isInRaid value should account for that
Health values are also potentially faulty due to disconnects (e.g. afaik, disconnecting and reconnecting in the nexus does not count as a death, but does show 0 health iirc?), so I switched to using the deaths chat message instead

Thanks for the PR!

LlemonDuck / tombs-of-amascut

tomb: death check for cursed phalanx detector #101

Issue:

Solution: