Closed sudoskys closed 4 months ago
The recent updates focus on enhancing user interaction with various messaging platforms by introducing a /learn
command to set system prompts. Modifications include reducing history lines in middleware, adding new functions across sender modules, refining help messages, and improving search functionality. Additionally, a key bug fix in search and refined logic in instruction handling enhance overall system robustness and user experience.
File Path | Change Summary |
---|---|
.../middleware/llm_task.py |
Reduced history lines from 10 to 8. |
.../sender/discord/... , .../kook/... , .../slack/... , .../telegram/... |
Introduced /learn command handling and updated help messages. |
.../util_func.py , .../kv_manager/instruction.py |
Added learn_instruction function and refined instruction handling logic. |
llmkira/extra/plugins/search/engine.py |
Corrected key used in search function from "Href" to "href". |
llmkira/openapi/trigger/__init__.py |
Improved trigger phrase sorting by priority. |
app/sender/telegram/event.py (1)
`17-17`: The addition of the `/learn` command to the help message is correctly implemented. Please ensure that the integration of the `/learn` command with the Telegram bot's command handling logic is thoroughly tested.app/sender/discord/event.py (1)
`22-22`: The addition of the `/learn` command to the help message is correctly implemented. Please ensure that the integration of the `/learn` command with the Discord bot's command handling logic is thoroughly tested.llmkira/kv_manager/instruction.py (1)
`26-32`: Enhancement to `read_instruction` method to handle absent or short instructions is well-implemented. Please ensure that unit tests are added to verify the behavior of the `read_instruction` method when the instruction is absent or shorter than 5 characters.app/sender/kook/event.py (1)
`41-41`: The addition of the `/learn` command to the help message is correctly implemented. Please ensure that the integration of the `/learn` command with the Kook bot's command handling logic is thoroughly tested.llmkira/openapi/trigger/__init__.py (1)
`47-50`: Sorting of trigger phrases by priority before processing is a good enhancement for managing triggers effectively. Please ensure that the integration of the sorted trigger handling with the rest of the system is thoroughly tested, especially in scenarios with multiple competing triggers.llmkira/extra/plugins/search/engine.py (1)
`65-65`: Correction of the key used to retrieve the link in `search_in_duckduckgo` function is necessary and well-implemented. Please ensure that the integration of the corrected search functionality with the rest of the system is thoroughly tested.app/sender/util_func.py (2)
`144-161`: Addition of the `learn_instruction` function to handle the `/learn` command is well-implemented. Please ensure that the integration of the `learn_instruction` function with the rest of the system is thoroughly tested, especially in scenarios where the instruction text is at the boundary conditions of length. --- `162-169`: Updates to the `login` function with documentation and type hints improve maintainability and clarity. Please ensure that the integration of the updated `login` function with the rest of the system is thoroughly tested.app/middleware/llm_task.py (1)
`154-154`: Reduction in the number of lines read from the message history is implemented as described. Please ensure that the reduction in the number of lines read does not negatively impact the functionality of the system, particularly in scenarios where the message history is critical for context.app/sender/slack/__init__.py (1)
`227-238`: The implementation of the `/learn` command in Slack looks correct and adheres to the expected functionality.app/sender/kook/__init__.py (1)
`279-293`: The implementation of the `/learn` command in Kook looks correct and adheres to the expected functionality.app/sender/telegram/__init__.py (1)
`230-238`: The implementation of the `/learn` command in Telegram looks correct and adheres to the expected functionality.app/sender/discord/__init__.py (1)
`266-277`: The implementation of the `/learn` command in Discord looks correct and adheres to the expected functionality.
Provide methods to customize system prompt
Summary by CodeRabbit
New Features
/learn
command across various platforms (Discord, Slack, Kook, Telegram) to set and reset the system prompt.Bug Fixes
Refactor
Documentation