search

LnL7 / nix-darwin

nix modules for darwin
MIT License
2.82k stars 431 forks source link

nixos/github-runner: fix build failure #1055

Closed siriobalmelli closed 3 weeks ago

siriobalmelli commented 4 weeks ago

Shellcheck complains:

   > args=(
   >      ^-- SC2054 (warning): Use spaces, not commas, to separate array elements.

Add a comment disabling shellcheck in this case and annotating why.

siriobalmelli commented 4 weeks ago

I see a build failure but seems to have no correlation with the minor fix being PRed.

Enzime commented 3 weeks ago

Could you instead wrap the argument to --labels with double quotes?

siriobalmelli commented 3 weeks ago

Respun and tested, works fine.