search

LnL7 / nix-darwin

nix modules for darwin
MIT License
2.82k stars 431 forks source link

Adjust default options #1057

Closed niklasravnsborg closed 1 week ago

niklasravnsborg commented 3 weeks ago

I missed these two options myself and added them in my fork but would like to merge them into the main repo:

Any feedback is warmly welcome. Thank you for your work!

niklasravnsborg commented 2 weeks ago

@Enzime I've added the test for the NSGlobalDomain.AppleSpacesSwitchOnActivate option. As far as I can see the defaults.finder options aren't included in tests at the moment so I didn't add the second one. Hope this is sufficient :)

Enzime commented 2 weeks ago

Can you also add the finder option to the tests?

niklasravnsborg commented 2 weeks ago

@Enzime as i mentioned previously, currently there aren't any tests for the finder options so i wouldn't know where to put them...

Enzime commented 2 weeks ago

The same file is fine

niklasravnsborg commented 1 week ago

@Enzime Done, I've went ahead and added tests for all finder options.