search

LnL7 / nix-darwin

nix modules for darwin
MIT License
3.19k stars 457 forks source link

jankyborders service option order above or below #1095

Closed aspauldingcode closed 1 month ago

aspauldingcode commented 1 month ago

Adds undocumented JankyBorders option order which can be set to above or below. Defaults to below because it causes issues for some users (hence the reason for not being documented). Helpful for covering the window frame on macos.

Enzime commented 1 month ago

Can you squash the commits into one commit?

aspauldingcode commented 1 month ago

Can you squash the commits into one commit?

There, I think I did it with af95f7b (#1095)

Enzime commented 1 month ago

Can you also update the jankyborders test?

aspauldingcode commented 1 month ago

Hm okay I think I did it.

update the jankyborders test

Enzime commented 1 month ago

Did you forget to push the changes for the tests? I don't see any new changes

aspauldingcode commented 1 month ago

forget to push

Yes.. no.. yes.. maybe. oops.

I think I did this correctly?

aspauldingcode commented 1 month ago

Hooray, my very first pull request (to any project, ever in my life) being merged. I will remember this moment!