Tracking issue for improving uninstalling

LnL7 / nix-darwin

nix modules for darwin

MIT License

3.23k stars 461 forks source link

Tracking issue for improving uninstalling #730

Open emilazy opened 1 year ago

emilazy commented 1 year ago

[x] Needs to clean up /run, esp. after https://github.com/LnL7/nix-darwin/pull/687
[x] Didn't delete /Applications/Nix Apps
[x] Should restore pre-nix-darwin configuration like nix.conf, bashrc and zshrc
[x] Change user shells that point to /run/current-system
[x] Flake uninstall procedure needs documenting in README
[x] Update documentation to try running the uninstaller from $PATH
[ ] Run checks after user runs uninstaller and direct them to report issues if the uninstaller failed
[ ] Check that /etc configuration got restored correctly
[ ] Check that no user shells point to /run/*
[ ] Check that run is not mentioned in /etc/synthetic.conf
[ ] Check that the only LaunchDaemons for org.nixos are org.nixos.nix-daemon and org.nixos.darwin-store
[ ] Reinstall nix and nss-cacert to /nix/var/nix/profiles/default

Enzime commented 1 year ago

I've fixed /Applications/Nix Apps not getting deleted in #687.

As opposed to the installer, I think uninstalling a flake-based system can be handled by the darwin-uninstaller, need to investigate further into any additional flake-specific logic that needs to be added.

emilazy commented 1 year ago

I've fixed /Applications/Nix Apps not getting deleted in #687.

That's what confuses me: I was using that version (nix run github:Enzime/...).

Enzime commented 1 year ago

I believe the uninstaller is not unloading launchd daemons before deleting the files, need to check this further.

zdcthomas commented 6 months ago

I thought I'd call this out here too, there's a small bootstrapping issue with the uninstaller being a derivation that has to be built to be run. If someone has any issues actually running nix, and they want to uninstall nix-darwin to get back to a clean state, they can't easily do that right now, since the docs recommend running from the derivation

Enzime commented 6 months ago

Some progress was made on this as of #806 as the uninstaller is now installed by default on all nix-darwin systems, accessible through darwin-uninstaller, so it no longer needs to be built, however I believe the uninstaller still depends on Nix.

The documentation should probably be updated to recommend running the uninstaller from $PATH

Enzime commented 3 weeks ago

Another thing to consider is what we want to do with users and groups created or managed by nix-darwin