search

LnL7 / nix-darwin

nix modules for darwin
MIT License
2.82k stars 431 forks source link

Add persistent others to dock #928

Closed rmgpinto closed 4 months ago

rmgpinto commented 5 months ago

Add persistent others to dock. Closes https://github.com/LnL7/nix-darwin/issues/927.

rmgpinto commented 5 months ago

@Enzime @Samasaur1

rmgpinto commented 5 months ago

@Samasaur1 I didn't notice, it's my linter and auto format on save. I've reverted the formatting changes.

rmgpinto commented 4 months ago

@Samasaur1 I can't seem to understand why the tests fail. Are you able to help?

Samasaur1 commented 4 months ago

Okay I manually checked the failing test on unstable, and it's only failing because of a missing newline. Seems like a false alarm; let me take a closer look and determine whether it's better to change the test or change the implementation back

Samasaur1 commented 4 months ago

Ah, okay, you need another newline in the test file

rmgpinto commented 4 months ago

Thanks @Samasaur1, tests passed.

Enzime commented 4 months ago

Can you rebase the PR?

rmgpinto commented 4 months ago

done @Enzime.

Enzime commented 4 months ago

Can you rebase your PR on top of the latest master and squash your commits? Ideally your branch shouldn't contain the fmt commits and should only contain your commits

rmgpinto commented 4 months ago

should be ok now @Enzime

rmgpinto commented 4 months ago

The tests seem to be flaky, sometimes that check passes, others it doesn't.

thegleich commented 4 months ago

This introduces a regression (warning) by using lib.mdDoc

mdDoc usage has been been removed in https://github.com/LnL7/nix-darwin/pull/932

rmgpinto commented 4 months ago

Fixing in https://github.com/LnL7/nix-darwin/pull/950