search

LnL7 / nix-darwin

nix modules for darwin
MIT License
3.19k stars 457 forks source link

treewide: remove lib.mdDoc #932

Closed wegank closed 7 months ago

wegank commented 7 months ago

lib.mdDoc has been removed in NixOS/nixpkgs#303841.

wegank commented 7 months ago

Oh, stable means 23.05, not 23.11...

purcell commented 7 months ago

Oh, stable means 23.05, not 23.11...

Presumably we'd want to bump the stable channel here for the purpose of GitHub Actions?

yonkeltron commented 7 months ago

This seems to work great in terms of fixing that bug, so great job. I was able to install nix-darwin using the flake method on a clean installation of macOS Sonoma 14.4.1 (23E224).

On my clean install, I noticed that it seems like pkg-config is broken. For example, I have several development libraries installed via my flake.nix and yet they aren't findable:

~ via 🐍 v3.11.8
❯ pkg-config --list-all

~ via 🐍 v3.11.8
❯ pkg-config --libs libsodium
Package libsodium was not found in the pkg-config search path.
Perhaps you should add the directory containing `libsodium.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libsodium' found

~ via 🐍 v3.11.8
❯ echo $PKG_CONFIG_PATH

Not sure if related, so asking for guidance if I should open a separate issue.

nwjsmith commented 7 months ago

@yonkeltron I don't think that's related, you should open a new issue. FWIW on a fresh nix shell I also see the same behaviour:


$ nix shell nixpkgs#libsodium nixpkgs#pkg-config
$ pkg-config --libs libsodium
Package libsodium was not found in the pkg-config search path.
Perhaps you should add the directory containing `libsodium.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libsodium' found
yonkeltron commented 7 months ago

@yonkeltron I don't think that's related, you should open a new issue.

You got it! I opened https://github.com/LnL7/nix-darwin/issues/934 and that should do it.

Love, +Jonathan

dominikb1888 commented 7 months ago

@tarc: Can confirm the approach below works for me as well.

I just updated my setup here to use github:wegank/nix-darwin/mddoc-remove and it fixed the error I was getting after flake update:

error: attribute 'mdDoc' missing
na-son commented 7 months ago

Working for me as well

hesthub commented 7 months ago

Another working build here using github:wegank/nix-darwin/mddoc-remove

purcell commented 7 months ago

^ It'll work now even without this change if you also update to the latest nixpkgs-unstable. (But with lots of errors printed out.)