LnL7 / nix-darwin

nix modules for darwin
MIT License
2.43k stars 407 forks source link

Add file or directory tile to Dock persistent others #950

Closed rmgpinto closed 1 month ago

rmgpinto commented 1 month ago

Added file or directory tile to Dock persistent others. This will either expand directories or open files directly.

rmgpinto commented 1 month ago

@Samasaur1 or @Enzime PR #928 doesn't work, I'm trying to fix it. However, the tests fail. The change is small but I'm not getting any clue about the error in the logs:

Did not find content from /nix/store/4r7rk4742d0kpjivcqfksvnrh0apc6wb-system-defaults-write/activate-user.txt in /nix/store/fx1rr7h100mavkwax300ckkyw0m72v9r-darwin-system-23.11pre558482.8a4282c38b6c+darwin4.7a694d1/activate-user

Are you able to help? Thanks

Samasaur1 commented 1 month ago

It's probably a similar error to last time. What I did to figure that out was to checkout the PR locally and run the tests, so that you have both of those files. Then I diffed them to see what was actually missing

rmgpinto commented 1 month ago

@Samasaur1 I am trying to run the PR locally, but it doesn't generate the file active-user. That's what I get in the logs.

Samasaur1 commented 1 month ago

@rmgpinto What do you mean it "doesn't generate"? The logs give you the paths to two files in the Nix store — those are what I'm talking about

Samasaur1 commented 1 month ago

You probably want to

opendiff /nix/store/4r7rk4742d0kpjivcqfksvnrh0apc6wb-system-defaults-write/activate-user.txt /nix/store/fx1rr7h100mavkwax300ckkyw0m72v9r-darwin-system-23.11pre558482.8a4282c38b6c+darwin4.7a694d1/activate-user

Find the block that is almost exactly the same. It should be pretty clear what the problem is

rmgpinto commented 1 month ago

@Samasaur1 thanks, it worked now. It's ready to merge.

rmgpinto commented 1 month ago

@Enzime ready with your proposed changes. Thanks

Enzime commented 1 month ago

Can you rebase over the latest master?

Everything else looks good to me :+1:

rmgpinto commented 1 month ago

done @Enzime