LnL7 / nix-darwin

nix modules for darwin
MIT License
3.19k stars 456 forks source link

feat: check if homebrew exists #961

Closed codingCoffee closed 6 days ago

codingCoffee commented 5 months ago

fixes #778

cc: @Enzime please recommend changes

codingCoffee commented 5 months ago

Also @joaothallis is there a way to evaluate the checkHomebrewInstall check only if the user has homebrew.enable = true in this nix configuration?

emilazy commented 5 months ago

You can use mkIf in the system.checks.text entry.

codingCoffee commented 1 week ago

Hey @Enzime, definitely interested in submitting the PR. I've commited the suggessions and resolved the conflicts. Please do tell if I need to make any more changes.

codingCoffee commented 1 week ago

Hey @Enzime, I just ended up creating a separate PR: https://github.com/LnL7/nix-darwin/pull/1160. Squashing was proving to be difficult since this is such an old PR. If it's okay can you close this and merge the other one?