Make the base image compatible with common network services

LnL7 / nix-docker

Docker images for the Nix package manager

MIT License

288 stars 41 forks source link

Make the base image compatible with common network services #24

Open mickours opened 5 years ago

mickours commented 5 years ago

My use case here to make cachix (https://cachix.org/) works out of the box, in a gitlab runner, but all those changes are standard.

I've done small changes to make complex network services works:

Add in /etc the iana files services + protocoles
Add in /etc the the ssl directory from cacert
Set the USER variable to ROOT
Make bash available at standard locations (/bin,/usr/bin)

mickours commented 5 years ago

Any review on this?

LnL7 commented 5 years ago

This seems a bit out of scope for this project, I made it as a bare minimum image to run nix-build in a completely isolated environment.

If you also want to run other software in this container I would suggest using eg. nixos/nix instead. Unlike this project it uses an actual linux distribution as the base image which should provide these kind of things you'd expect to be available on a normal system.

mickours commented 5 years ago

Thanks for the feedback. Since it seems to not fit with your project goal I understand that it would not be merged as-is. Maybe, when I find some time to do this, I can provide you some kind of Cachix enabled image flavor (like the SSH one) that can be added to the images provided in default.nix.

LnL7 commented 5 years ago

Yeah, a separate cachix image sounds good.

bxrt commented 4 years ago

I made it as a bare minimum image to run nix-build in a completely isolated environment.

If you also want to run other software in this container I would suggest using eg. nixos/nix instead. Unlike this project it uses an actual linux distribution as the base image which should provide these kind of things you'd expect to be available on a normal system.

Please add this quote or something along its lines to the top of the README to explain the different purposes of [nixos/nix] and this image. Now that this is clear to me, I will no longer attempt to use it for more than a remote builder.