search

LnL7 / vim-nix

Vim configuration files for Nix http://nixos.org/nix
MIT License
288 stars 26 forks source link

Upstream syntax highlighting? #47

Closed jsoo1 closed 1 year ago

jsoo1 commented 2 years ago

Hello! Thank you for vim-nix! Would you be alright if someone were to try to upstream the syntax highlighting from your plugin into {neo,}vim?

jsoo1 commented 2 years ago

According to the vim documentation on the subject some maintainer would be listed at the top of the syntax file who would send updated versions to Bram. For example, see the haskell syntax file.

Edit: To be clear, I wouldn't expect LnL7 to be the maintainer.

equill commented 2 years ago

I'm willing to maintain that bridge, fwiw.

jsoo1 commented 1 year ago

I think if enough time goes by I will put in a patch to the vim tree naming you @equill as the point of contact. Because this plugin is MIT licensed I believe it should suffice to keep a copy of the license and attribution to LnL7 in the upstream plugin.

equill commented 1 year ago

That works for me. Just give me a heads-up when you've done it, and I'll pick it up from there.

jsoo1 commented 1 year ago

As of https://github.com/vim/vim/commit/86b4816766d976a7ecd4403eca1f8bf6b4105800 the syntax from vim-nix is in the vim tree. Thank you again to @equill and @LnL7 .

LnL7 commented 1 year ago

Thanks for looking into this! I thought about this at some point but that was rather early on and I figured somebody would make a better package at some point 😁 since there are still some problems with indentation.

Some thoughts: Depending on what gets added to vim-nix, it might make sense to only upstream the syntax/indentation and not commands, etc. No idea what the approach is for upstream vim. Once nixpkgs is updated it might be good to get rid of some of the extra customization that happens there, nog sure if that's still in place.

jsoo1 commented 1 year ago

Thanks for looking into this! I thought about this at some point but that was rather early on and I figured somebody would make a better package at some point 😁 since there are still some problems with indentation.

You're welcome and thank you for all your work in the nix ecosystem!

I am pretty sure vim-nix remains the de-facto standard 😄. Ah, how software evolves, huh?

Not to worry, though, only the syntax highlighting made it upstream. Though indentation could be nice, should it get fixed 😃.

Some thoughts: Depending on what gets added to vim-nix, it might make sense to only upstream the syntax/indentation and not commands, etc.

I agree. I'm not even sure what kind of commands and extras would be accepted upstream.

No idea what the approach is for upstream vim. Once nixpkgs is updated it might be good to get rid of some of the extra customization that happens there, nog sure if that's still in place.

Good call. I can't recall but I did see one recent PR which spurred some of this work.