search

LoGaCulture / LUTE

LUTE stands for LoGaCulture Unity Toolkit/Engine. A Unity based tool to create narrative rich location-based games for the purposes of heritage preservation.
MIT License
0 stars 0 forks source link

Deleting location variables from engine does not delete from map #18

Closed Jacki3 closed 4 weeks ago

Jacki3 commented 1 month ago

Describe the bug When removing location variables from the engine, their pins still remain.

To Reproduce Steps to reproduce the behavior:

  1. add location
  2. remove this location
  3. open the map and see that the pin remains

Additional context Seems as though the variable is not fully removed.

Jacki3 commented 1 month ago

Essentially what happens is that the variable is correctly removed but the map window drawing is not updated or informed of this. Closing and opening the map window will ensure that the pin is removed but it would be nice to see this happen in 'real time'.

See EngineEditor.cs line 117 comment for specific implementation point.

Jacki3 commented 4 weeks ago

Upon removing the variable from the list a method on the MapboxControls.cs class is called which queries the list of locations it has with the location that is removed. If this location is found we remove all references it has on the Map thus removing the location pin from the map when deleting the location as a variable.

Updating the RITE sheet with this fix and calling this closed.