search

LoL-pj / LoL-VC

6 stars 0 forks source link

New posts have to come at the beginning #84

Closed LeonTeraoka closed 3 years ago

LeonTeraoka commented 4 years ago

Fixes #74 Added your suggestion (order method)

LeonTeraoka commented 3 years ago

First, I changed the "id" to "updated_at". Because the goal is to show the latest update from the top. Not the order in id. I also added the order method on the search to make as same as the above. Now the search can also show the updates from the top.

Regarding the before_action, I understand there is a redefinition of the search. But I didn't get the reason why do we have to delete the search on that. Because my local test works correctly, and I can not figure out what is wrong. But I think you are correct, so I fixed it. It will be nice if you could clarify this for me. I'm looking forward to your explanation.

Fixes #74

LeonTeraoka commented 3 years ago

Alright. Thanks for your review. Let me combine them before I merge.