LoLab-MSM / PyDREAM

MT-DREAM(ZS) algorithm for model optimization, calibration, selection
GNU General Public License v3.0
49 stars 33 forks source link

Confusion between likelihood and log likelihood #23

Open noashin opened 4 years ago

noashin commented 4 years ago

One of the parameters of pydream.core.run_dream is called "likelihood" and the documentation specify it to be "A user-defined likelihood function".

It seems though that the code is actually expecting a log-likelihood function, as seen in pydream.model.total_logp line 30:

loglike = self.likelihood(q0)

This can be easily solved by changing the parameter name to be log_likelihood and changing the documentation accordingly.

ortega2247 commented 4 years ago

You are right. Thanks for pointing it out. We will be updating the parameter name and the documentation accordingly.

Best, Oscar