LoLab-MSM / pysb

Python framework for Systems Biology modeling [Lopez Lab Mods]
BSD 2-Clause "Simplified" License
6 stars 8 forks source link

ComplexPattern.is_equivalent_to() requires identical bond numbering #16

Closed lh64 closed 6 years ago

lh64 commented 9 years ago

From the code:

FIXME the literal site_conditions comparison requires bond numbering to be identical,

 #   so some sort of canonicalization of that numbering is necessary.

Currently, a comparison of the ComplexPatterns A(b=1)%B(a=1) and A(b=2)%B(a=2) would return False. This needs to be fixed, especially since new code in Solver.run() uses the ComplexPattern.is_equivalent_to() method.

alubbock commented 6 years ago

Resolved in pysb/pysb#285