search

LoLab-MSM / pysb

Python framework for Systems Biology modeling [Lopez Lab Mods]
BSD 2-Clause "Simplified" License
6 stars 8 forks source link

Pysb flat export #35

Closed JamesPino closed 7 years ago

JamesPino commented 8 years ago

Doesn't output all the functions from pysb needed for the model. When exporting the earm model, it doesn't write out to include MatchOnce. Simple fix to add it to the file, but might be a better way to do it. Or just use from pysb import *

alubbock commented 8 years ago

Is the lack of MatchOnce the only problem? I can add it in and create a pull request if so.

It's probably better to keep the from pysb import ... imports explicit rather than using the * wildcard, in case the classes in core change in the future.

JamesPino commented 8 years ago

I don't know if it is only MatchOnce. I was thinking of a way to find only functions that are used. Right now it writes a list of things, even if they are used or not. For earm, Expression, Compartment, ANY, WILD are all written out but not used. Not sure if it is worth checking and only writing out what is needed? Or just add MatchOnce, plus any other functions defined in core.py that could ever be called.

JamesPino commented 8 years ago

It looks like MatchOnce is the only other function though. So probably best just to add that.