search

LoLei / razer-cli

CLI for configuring Razer devices
GNU General Public License v3.0
89 stars 11 forks source link

Add code submitted by @GM-Script-Writer-62850 #42

Closed LoLei closed 3 years ago

LoLei commented 3 years ago

Please review @GM-Script-Writer-62850

Close #39 Close #40 Close #41

GM-Script-Writer-62850 commented 3 years ago

seems to work as intended on my end, though it looks like the readme.md file need a update on usage, lacks poll and sync

GM-Script-Writer-62850 commented 3 years ago

was looking other some stuff and noticed this:

    rgb = []
    rgb.append(r)
    rgb.append(g)
    rgb.append(b)

    return rgb

you do know you could write that in one short line right? return [r,g,b]

LoLei commented 3 years ago

You can refactor that in another patch if you want.

EDIT: Just added it here.