Inverted IQ setup not used for Downlinks for SX126x

LoRaWanMiniMouse / Mini-Mouse

LoRaWan Stack

28 stars 14 forks source link

Inverted IQ setup not used for Downlinks for SX126x #11

Closed vanthome closed 6 years ago

vanthome commented 6 years ago

Hello, I think there is a major bug in the function SX126x::SetPacketParamsLora( uint8_t payloadSize ). It is used for Tx and Rx while for Rx IQ_INVERTED should be used. Can you confirm this? I'm open to create a PR to fix it then if you want. BG

LoRaWanMiniMouse commented 6 years ago

Hello, thomas, You are right , it has appear since the merge introducing the fsk , i will correct it assap Best FH

vanthome commented 6 years ago

It works