Proposed Enhancements - Githubissues

vanthome commented 6 years ago

Hi, I'm working on an implementation for another MCU and I have some questions/ suggestions.

How do you plan to differentiate between the MCU implenentations because you can only one in ApiMcu.h? I propose to use a symbol?
The code to write to SPI you propose does not seem to work for me, we use:

  uint8_t rxDat;
  if (HAL_SPI_TransmitReceive(&hspi1, (uint8_t *) &outval, (uint8_t *) &rxDat,
      1, HAL_MAX_DELAY) == HAL_OK) {
    //DBG_PRINTF("HAL RX DAT: %u\n", rxDat);hspi1
    return rxDat;
  }

Why are you using the low level functions for SPI but not the other peripherials? I think just using HAL is just fine.

wait_ms() is used in sx1276.cpp but not defined in the API.
mbed.h should only be included if a symbol MBED for example is set
extern Serial pcf is also not compatible to any environment and should be put behind a symbol
void SX126x::WriteCommand should return the as it is needed for commands like GET_DEVICE_ERRORS

LoRaWanMiniMouse commented 6 years ago

Hi, I agree with your comments , I have myself implemented an other mcu STM32L0 without mbed dependencies. If you want i can send you the keil project. Best

vanthome commented 6 years ago

Hi, thx for the answer! I took the published code and merged with mine and I think it should work. I can't get the device to work however. Can you tell me whether the SX126x code actually works i.e. was tested on actual hardware? I can't seem to get it to work with an SX1261. Btw. I'm also missing the antenna Dio2 switch functionality for the SX126x.

BG

vanthome commented 6 years ago

Update: I have further analyzed the issue and I can't seem to get the IRQ_TX_DONE (and no other as well) no matter what I do. There seems to be no device error. Can you help me with this?

LoRaWanMiniMouse commented 6 years ago

Hi thomas. What is your hw platform? Could you share with me your project. Best Fabien

Le jeu. 24 mai 2018 à 16:15, Thomas Hoppe notifications@github.com a écrit :

Update: I have further analyzed the issue and I can't seem to get the IRQ_TX_DONE (and no other as well) no matter what I do. There seems to be no device error. Can you help me with this?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LoRaWanMiniMouse/Mini-Mouse/issues/7#issuecomment-391730731, or mute the thread https://github.com/notifications/unsubscribe-auth/Ag-U0tIfnSeGzAjLexuUjkaCnsKwS8Mgks5t1sBjgaJpZM4UErxo .

vanthome commented 6 years ago

Sure, can you send me an email to then I can send you a link?

LoRaWanMiniMouse / Mini-Mouse

Proposed Enhancements #7