search

LoadedCamel / MidsReborn

Mids' Reborn : Hero Designer
GNU General Public License v3.0
24 stars 8 forks source link

Set Bonus Finder is missing some effect strength values for damage buffs #124

Closed carl-eastlund closed 2 years ago

carl-eastlund commented 2 years ago

Describe the bug In the Set Bonus Finder window, there are no effect strength values for damage buff values of 2%, 3%, or 4%.

To Reproduce In the Set Bonus Finder window, select the Bonus Effect of "DamBuff(All)" and leave Effect Strength at "All". Scrolling through the list, sets with damage bonuses of 2%, 3%, and 4% are included.

The Effect Strength values I see are "All", 68, 14, 1, 2, 3, 4, and 21. The lists for 68, 14, and 21 are empty. The values of 1, 2, 3, and 4 correspond to damage buffs of 1%, 1.5%, 2.5%, and 3.5%. There are no values (other than "All") for the sets with damage bonuses of 2%, 3%, or 4%.

Expected behavior Presumably, every bonus value should have a corresponding Effect Strength value.

Version Mids' Reborn v3.1.2.5, DBVersion: 2021.1215

Additional context It's possible this is a DB error instead of a code error, I'm not sure what the underlying cause is.

zethriller commented 2 years ago

Working on it. The effects strength list has a lot of issues - top of them is the values you see have no % sign when they are percentage and they are rounded to integers.