LoadedCamel / MidsReborn

Mids' Reborn : Hero Designer
GNU General Public License v3.0
24 stars 8 forks source link

Mids import of 'build.txt' file drops power from Marine Affinity #187

Closed srmalloy closed 2 months ago

srmalloy commented 2 months ago

Describe the bug I saved my Necro/Marine MM's build from the game using /build_save, and imported it into Mids. The file loaded with no error, but showed no power taken for level 41 (character is 43). Comparing the build as imported with a reference build that I'd downloaded from the Homecoming forums, I saw that "Power of the Depths", which I'd taken at level 30, was not tracked in the build -- "Kick" and all subsequent power choices were moved up one slot, leaving the level 41 power choice empty. All of the slot and enhancement information from the shifted powers show correctly; only the level 30 choice is missing.

The build.txt file has the lines

Level 28: Mastermind_Buff Marine_Affinity Wellspring Attuned_Luck_of_the_Gambler_F (1) Attuned_Red_Fortune_E (1) Attuned_Red_Fortune_A (1) Attuned_Red_Fortune_B (1) Level 30: Mastermind_Buff Marine_Affinity Call_Depths Crafted_Recovery (25) Level 6: Pool Sorcery Mystic_Flight Crafted_Fly (25)

To Reproduce Steps to reproduce the behavior:

  1. Save the attached 'build.txt' file.
  2. Open 'build.txt' in a text editor, verify that the power selected for level 30 shows as "Call_Depths"
  3. Open MidsReborn
  4. Select File->Open, navigate to folder where 'build.txt' was saved, and select file.

Expected behavior The expected behavior was to have "Power of the Depths' appear as the level 30 power selection, instead of being ignored completely.

Additional context To Ameliorate If the power name "Call_Depths" in the build.txt file is changed to "Power of the Depths", then the build.txt file imports correctly. It appears that MidsReborn is not correctly identifying the power name that the Homecoming client uses to save this power choice. This does not fix the problem, but it does provide a workaround.

Desktop (please complete the following information):

zethriller commented 2 months ago

Possible issue with Barrier Reef still using internally its old name (Wellspring) Also check ingame Power of the Depths internal name. Investigating.

zethriller commented 2 months ago

Done. Call_Depths -> Power_of_the_Depths Barrier Reef is working ok.