Previously existing Mids Reborn saved builds lack Quick Form and are inconsistent in display of Extra Powers

[Jacke4913]

Describe the bug When loading a build created under a previous version of Mids Reborn, the display often lacks the Quick Form toggle. The display at the bottom of Extra powers, including Prestige Powers and Incarnate Powers, are inconsistent, sometimes lacking powers the build includes and displaying the powers in different orders.

To Reproduce Steps to reproduce the behavior:

1. Install Mids Reborn v3.
2. Update Mds Reborn v3.
3. Load various saved files from previous Mids Reborn versions.
4. Observe how the display of extra powers is inconsistent and cannot be fixed with simple actions.

Expected behavior There are many Mids builds in existence. Although it is challenging, Mids Reborn v3 should be able to load these older files and display the build with as minimal issues as possible. This should be especially true of recent Mids Reborn saved builds. Any needed fixes should be simple to do to make the build display properly.

Screenshots

Here is a build created back on 2020 March 8. https://www.dropbox.com/s/0t53o2g9tki9enk/Jacke%20Dark%20-%202%20-%20Blaster%20AR-Dev-Force%20Rune%20Recall.20200328.mxd?dl=0

Here it is displayed by Mids Reborn v2 with the 2020 Dec 24 Unpolished database, in its 4-column form which has no display issues. https://www.dropbox.com/s/wf35ujrymu9ueu0/20210106e.Mids_Reborn.3.0.1.9.Jacke_Dark.2.20200328.v2.11.png?dl=0

Here is that same build loaded by the current Mids Reborn v3. https://www.dropbox.com/s/ss06gtqpc4culi8/20210106e.Mids_Reborn.3.0.1.9.Jacke_Dark.2.20200328.v3.12.png?dl=0

Note that v3 fails to display all the powers that v2 displays. It doesn't show the Quick Form toggle even though the build has a Sniper power in its primary powerset. Not all the Prestige Sprints display. When the Prestige Powers window is used to remove unused Prestige Sprints, the selected power Prestige Power Surge disappears. https://www.dropbox.com/s/n7r812mlhdxh1nc/20210106e.Mids_Reborn.3.0.1.9.Jacke_Dark.2.20200328.v3.13.png?dl=0

Here is a build saved with Mids Reborn v2 with the 2020 Dec 24 Unpolished database today 2021 Jan 7. https://www.dropbox.com/s/g8xku6b2y06gzeu/Jacke%20Dark%20-%201%20-%20Blaster%20AR-Dev-Mun%20Rune%20Recall.20210107.mxd?dl=0

Here it is displayed by Mids Reborn v2 in its 4-column form which has no display issues. https://www.dropbox.com/s/dm9hsyx6x0hxc66/20210106f.Mids_Reborn.3.0.1.9.Jacke_Dark.1.20210107.v2.14.png?dl=0

Here is that same build loaded by the current Mids Reborn v3. https://www.dropbox.com/s/mlhaboj8pbdav0n/20210106f.Mids_Reborn.3.0.1.9.Jacke_Dark.1.20210107.v3.15.png?dl=0

Note that the Prestige Sprints all display here, but the Quick Form toggle is still missing.

Looking at both Mids Reborn v3 screenshots above, note that sometimes the Prestige Powers show before the Incarnate Powers, sometimes they show after them. There should be a consistent order of displaying Extra Powers in all cases, no matter what order they were added to the build.

As well, the Mids Reborn v2 and v3 windows were set to the same size. v2's display is more clear. v3 at the same sized window has text cut off and slightly worse use of UI space. Certainly for the 4-column view, v2's more vertical layout of Extra powers is better than v3's more horizontal layout.

Desktop (please complete the following information):

• OS: Windows 10
• Application Version 3.0.1.9
• Database Version 20.1229

[Crytilis]

We value feedback, and understand you like 2.x better. With that being said, if you believe this is simple to fix, please fork and submit a PR.

On Wed, Jan 6, 2021, 11:02 PM Jacke4913 notifications@github.com wrote:

Describe the bug When loading a build created under a previous version of Mids Reborn, the display often lacks the Quick Form toggle. The display at the bottom of Extra powers, including Prestige Powers and Incarnate Powers, are inconsistent, sometimes lacking powers the build includes and displaying the powers in different orders.

To Reproduce Steps to reproduce the behavior:

1. Install Mids Reborn v3.
2. Update Mds Reborn v3.
3. Load various saved files from previous Mids Reborn versions.
4. Observe how the display of extra powers is inconsistent and cannot be fixed with simple actions.

Expected behavior There are many Mids builds in existence. Although it is challenging, Mids Reborn v3 should be able to load these older files and display the build with as minimal issues as possible. This should be especially true of recent Mids Reborn saved builds. Any needed fixes should be simple to do to make the build display properly.

Screenshots

Here is a build created back on 2020 March 8.

https://www.dropbox.com/s/0t53o2g9tki9enk/Jacke%20Dark%20-%202%20-%20Blaster%20AR-Dev-Force%20Rune%20Recall.20200328.mxd?dl=0

Here it is displayed by Mids Reborn v2 with the 2020 Dec 24 Unpolished database, in its 4-column form which has no display issues.

https://www.dropbox.com/s/mhha424xtgoks1s/20210106e.Mids_Reborn.3.0.1.9.Jacke_Dark.2.v2.11.png?dl=0

Here is that same build loaded by the current Mids Reborn v3.

https://www.dropbox.com/s/wr965556r74vp5k/20210106e.Mids_Reborn.3.0.1.9.Jacke_Dark.2.v3.12.png?dl=0

Note that v3 fails to display all the powers that v2 displays. It doesn't show the Quick Form toggle even though the build has a Sniper power in its primary powerset. Not all the Prestige Sprints display. When the Prestige Powers window is used to remove unused Prestige Sprints, the selected power Prestige Power Surge disappears.

https://www.dropbox.com/s/n1p4zufjd3uwwrc/20210106e.Mids_Reborn.3.0.1.9.Jacke_Dark.2.v3.13.png?dl=0

Here is a build saved with Mids Reborn v2 with the 2020 Dec 24 Unpolished database today.

https://www.dropbox.com/s/g8xku6b2y06gzeu/Jacke%20Dark%20-%201%20-%20Blaster%20AR-Dev-Mun%20Rune%20Recall.20210107.mxd?dl=0

Here it is displayed by Mids Reborn v2 in its 4-column form which has no display issues.

https://www.dropbox.com/s/2s6ipay8nsf3crz/20210106f.Mids_Reborn.3.0.1.9.Jacke_Dark.1.v2.14.png?dl=0

Here is that same build loaded by the current Mids Reborn v3.

https://www.dropbox.com/s/ltq6w2mv4miit16/20210106f.Mids_Reborn.3.0.1.9.Jacke_Dark.1.v3.15.png?dl=0

Note that the Prestige Sprints all display here, but the Quick Form toggle is still missing.

Looking at both Mids Reborn v3 screenshots above, note that sometimes the Prestige Powers show before the Incarnate Powers, sometimes they show after them. There should be a consistent order of displaying Extra Powers in all cases, no matter what order they were added to the build.

As well, the Mids Reborn v2 and v3 windows were set to the same size. v2's display is more clear. v3 at the same sized window has text cut off and slightly worse use of UI space. Certainly for the 4-column view, v2's more vertical layout of Extra powers is better than v3's more horizontal layout.

Desktop (please complete the following information):

-

OS: Windows 10

-

Application Version 3.0.0.0 installer

-

Database Version 20.1229

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Reborn-Team/MidsReborn/issues/50, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEOMWKDI3TJALQ26Y37SOJLSYU57HANCNFSM4VYOWNIQ .

[Jacke4913]

We value feedback, and understand you like 2.x better. With that being said, if you believe this is simple to fix, please fork and submit a PR.

I did not say this issue was simple to fix. I said under Expected Behaviour that the display of files saved by a previous version of Mids Reborn should be complete and consistent and if needed to be fixed, the display fixing should be simple. I quote from my initial post.

Expected behavior There are many Mids builds in existence. Although it is challenging, Mids Reborn v3 should be able to load these older files and display the build with as minimal issues as possible. This should be especially true of recent Mids Reborn saved builds. Any needed fixes should be simple to do to make the build display properly.

These display issues exist with new builds made completely in Mids Reborn v3, especially in the Incarnate window. I am in the process of submitting more bug reports.

[Bopper-CoH]

Describe the bug When loading a build created under a previous version of Mids Reborn, the display often lacks the Quick Form toggle.

Jacke, v3.0.3.1 should have a fix that would no longer cause powers from old builds to overlap. I believe this is why you were not seeing the Quick Form toggle, as a different power was trying to share the same slot. Metalios has created new code that will re-sort the inherents when you load a build, which should allow any overlapping issues from old builds to re-sort themselves out. Can you verify that your builds now produce the Quick Form button? If so, we will go ahead with closing this bug report. Thank you.

[Jacke4913]

I've done some testing with v3.0.3.1 and it appears old builds now show much better.