SofiBretz
commented
4 years ago Changes required ♻️
Hello @LoboArkano 🌟
Great work on this project, but you need to fix the issues below before moving on ⬇️
- [x] Missing 1 new on large, medium and small sections, consider adding this as the original page.
Medium section:
-
[x] 'Latest news' has to be on the left side, consider follow the proportions of the original page.
-
[x] On the 'us, world, business, tech & science, culture, and sports' sections, the proportion of the images on the right segment has to be as the original page.
Small section:
-
[x] 'More stories' section has to be placed below the 'the debate' section. Consider also, align the rows to the left.
-
[x] Missing some news and the title on the 'featured stories' section, consider place this section the same order as the original page and put the complete elements of news together. (after 'the debate' section it should continue 'more stories' section).
-
[x] Consider fixing the 'Culture & travel' title as the original page.
-
[x] Consider fix 'latest news' section proportions as the original page.
-
[x] Please take a look at how the original page looks on the small screen and pay attention to the order and proportions of every section. You can do it! You are doing a great job, this is a learning process. :+1:
-
[x] Make sure that basic CSS bad practices are not used (article for support ) (screenshot from Pathwright).
-
no repeating of the same rule
-
no ID selectors for multiple elements
-
no
!importoverusing -
no inefficient selectors
-
no inline styling
After making the required changes please submit a new code review request Good luck! 🍀 You are almost there! 💪
SofiBretz.
sumancrest0001
This project use bootstrap classes to design the columns of the page.