LocalData / localdata-tiles

A tileserver for LocalData
5 stars 2 forks source link

Add tile rendering for features #147

Closed hampelm closed 9 years ago

hampelm commented 9 years ago

Ready for review.

I still want to add a tile zoom limit (specifically return a blank tile at far zooms)

hampelm commented 9 years ago

Will transfer / respond to questions from #144 later today so we can keep track of them

hampelm commented 9 years ago

From #147:

It'd ideally be nice to factor out the S3/knox putBuffer error handling into a promise-returning function. We'd probably need to wrap the underlying errors or failure scenarios (non-200 status). Then the catch function will mostly be some logic to decide what to log, which is less fragile than deciding that we have indeed encountered an error and passing control to the appropriate continuation.

I think we ought to skip this for now and log it as an issue for later.

hampelm commented 9 years ago

@prashtx This is ready for the next round of review. I'm also going to test on my dev server.

prashtx commented 9 years ago

Other than the postgres note, LGTM.