search

LocalGod79 / UrsaPolaris

An Endless Sky post-main-arc universal outfitter station story
GNU General Public License v3.0
20 stars 14 forks source link

Contribution welcome? #11

Open lukearndt opened 5 years ago

lukearndt commented 5 years ago

Hello! I recently took this mod for a spin. I enjoyed it overall, so thanks for making it.

Along the way, I spotted some things that could be improved upon: writing, formatting, typos, that sort of thing.

I'm considering editing the mission files to tidy up grammar, tone, formatting, and overall flow. Would such a contribution be welcome?

Figured it would be a good idea to check before spending a bunch of time on it. 😄

LocalGod79 commented 5 years ago

Hello!

thanks for the praise, and yes - i'm both: aware that the writing needs work; and welcome improvement edits.

that said, i'd recommend making smaller pull requests that are easy for me to review, rather than pouring many hours into a wholesale edit.

in the past, people have tried making pull requests with wholesale changes, such that github could not display all the differences, and after merging their "fixes" and play testing it, found some very distasteful changes, so ended up reverting the repository, rather than trying to sort out the changes that were worth having (which were not obvious).

lukearndt commented 5 years ago

That makes total sense. I'll try to keep any contributions focused and easy to review.

LocalGod79 commented 5 years ago

i'm looking forward to improving Ursa Polaris together:

it's always been an aim to make UP into a shape that would be "mergeable" into the main branch; and while i expect that nearly all of it is already there (graphics assets, outfit additions, storyboard) meet standards, i hold the plugin to a standard that is perhaps higher than necessary to make it "vanilla" ready, and want more from it before i actually make the pull request...

one of the things that i've noticed in recent years is that UPS should probably be more central than the Wei system, and moving it to Deneb is probably better (but the story logistics changes are more than i have time for these days)...just something to consider as you proceed...