LocalGod79 / UrsaPolaris

An Endless Sky post-main-arc universal outfitter station story
GNU General Public License v3.0
19 stars 14 forks source link

Is the Polar Core supposed to do hull damage or give strength? #2

Closed Alkallid closed 8 years ago

Alkallid commented 8 years ago

I might use this as a hub because this place is dead.

In OS1, you forgot the ending comma for one of James' sentences.

Alkallid commented 8 years ago

In OS2, comma before when he spots you.

Alkallid commented 8 years ago

Also, 'spot' and 'he' are overused, you can just cut out "he drags you..."

Alkallid commented 8 years ago

OS3: os3b: Ships shan't have an apostrophe.

Alkallid commented 8 years ago

I meant "it's scope..." Sorry, can't edit my comments right now.

Alkallid commented 8 years ago

Comma should be before so in the line where he roasts your New Greenland ass. (Although incorrectly)

Alkallid commented 8 years ago

"Well, we're starting to assemble a team of mostly engineers, and my favour-owing engineer cousin friends here have managed to convince six fellow Syndicate employees to end their contracts as well, and are all joining our organization." You really want to restructure this run-on.

LocalGod79 commented 8 years ago

wow - thanks - i'll get on these soon, i promise.

yes, the Polar Core is supposed to do hull damage (which happened only when the shields were down in 0.8.x, but will now also happen when suffering "disruption damage" - it's a balance point to all the goodies that it imparts in an otherwise broken package)

Alkallid commented 8 years ago

I'll probably search more later, right n ow I'm scanning Enigma Corp.

LocalGod79 commented 8 years ago

i'm not averse to pull requests...

Alkallid commented 8 years ago

I'm not willing enough to bother... Yet

Alkallid commented 8 years ago

OS4 "You greet him, he stands up..." Either make that a semicolon or add an 'and.'

Alkallid commented 8 years ago

"A top tier outfitters..." "Well, we have a crack group of engineers already working aboard Honest Abe. I helped them remove all the fancy stuff that I'd been collecting back in the day. Mostly stuff that was mothballed because the business folk didn't want invest in making them more viable, but there was some other stuff in there, too. It's all aboard Honest Abe now, either being reverse engineered, improved, or loaded up for use. The Marius was a sweet ship, though…To her!" Wait, did he help strip the Marius or the Abe? Clarify a bit Space before the toast Fidn't want to invest

You meet his toast. "Honest Abe is a good ship, and better serves our purposes…" he continues "which I imagine you're beginning to question, since we've talked about opening a top-tier outfitters, and spent a fair bit apparently recruiting weapons engineers. That's only partly true; we've simultaneously recruited the talent required to assemble an asteroid outpost."`

Comma after "he continues..."

Alkallid commented 8 years ago

Good choice would be better than thinking; you didn't really have an idea.

I'm also not sure, but shouldn't it be hundreds of millions' worth...?

Alkallid commented 8 years ago

OS5 desc.- Rendevous is one word, and you forgot the period.

Alkallid commented 8 years ago

Are descriptions supposed to not be sentences?

Alkallid commented 8 years ago

It's done. https://github.com/Alkallid/UrsaPolaris/blob/master/data/UPMissions.txt If you could explain how to PR, that'd be great. I only "forked," and don't know how to give it to you.

Alkallid commented 8 years ago

I will be back in 18 hours or so.

LocalGod79 commented 8 years ago

it's late - i'll edit this post in the morning with some instructions. if you get this before then, are you using the github desktop application?

Alkallid commented 8 years ago

Nope, browser. I could've gotten it, though, I think.

LocalGod79 commented 8 years ago

so, if you get the desktop client, it's super easy.

the client clones the repository locally. you create a branch, switch to your operating system's file management, and replace the "UPMissions.txt" file with the one you've corrected. submit pull request.

from the browser (on your fork page) there should be a link at the right side: "Pull request", at the top of the file list (under the code tab), next to "Compare"

Alkallid commented 8 years ago

When I go to pull request, it says to compare branches; I type mine in?

LocalGod79 commented 8 years ago

i'm not sure which button you pressed - white or green?

edit; from your fork page, it should automatically make the comparison, and "Files Changed" will not be 0...

Alkallid commented 8 years ago

I think I got it. However, since my computer is sort of broken, I have to use the browser base, so it'll be more complicated, I guess. I understand this though.

LocalGod79 commented 8 years ago

i think, after merging your p.r., all of these are addressed.