search

LocalGovIMS / localgov-ims

LocalGov IMS codebase for the Payment Portal, Admin and API projects
GNU Affero General Public License v3.0
2 stars 0 forks source link

Enable multiple suspense items to be processed at once #5

Open kingstonrichard opened 2 years ago

kingstonrichard commented 2 years ago

Can we revisit the option to choose multiple items from suspense and allocate them as a group to the same place please? We had problems initially as the system was lumping them together and then we couldn't clear them properly but we might be able to sort something out if we have some more time to investigate.

bmbc-dev-detec commented 2 years ago

This could just be to a tweak to some UI code stopping multiple transactions being selected. This would revert it to it's original form - and hopefully the suspense journal allocation strategy can still accept multiple transactions (it does)

bmbc-dev-detec commented 2 years ago

The 'problems' described in the original comment don't provide enough information.

As soon as we reintroduce the ability to select multiple items as issue arises: As data from the suspense item (e.g. the narrative, and import Ids) is used within the journal transaction. If we're selecting multiple suspense items, which one do we pick this data from?

I'm not sure if the implications of reintroducing this ability have been fully considered by the finance team. @zoecrosby, what are your thoughts?

zoecrosby commented 2 years ago

@bmbc-dev-detec I think that if we select multiple suspense items they should all go to the same place e.g. 1 new transaction and therefore it would be ok to just use the details of the first suspense item as they should in theory all be the same

bmbc-dev-detec commented 2 years ago

I've looked further into this - and there is a fundamental issue with it: A transaction has an option to 'View suspense'. That links through to one suspense item. If we journal from multiple suspense items it is impossible to know which suspense item to view, and even if we defaulted to one, the suspense details page that's shown would only show data relating to that suspense item.

I don't think it's possible to achieve this @zoecrosby

bmbc-dev-detec commented 2 years ago

The cost/benefit ratio here doesn't make it worth completing this item at the moment. It would be useful to find out if other councils deem this ability necessary, or just nice to have.