Closed JBRPG closed 6 years ago
Add field function has been improved to become modular so it can work with all views, including spreadsheet and map for create form. Did the best I could to cut down the many obvious bugs during the implementation.
I felt proud to finally to submit a pull request filled with significant improvement to adding fields through forms and spreadsheet. Also revised the error handling system by simplifying the HTML output and having a dedicated collection of strings to store and give out the appropriate message.
I also managed to get most of the tests updated to reflect the changes. Even if I ended up having a few tests have confusing errors due to the changes made to the structure quite some time ago, I still feel proud that I put effort in updating existing tests to accommodate the changes from the actual files.
I do not know when I will be returning to the tests to finish off the errors or whatnot, but the important thing is that I managed to make the web browsing experience better for the end-user.
A few things to fix:
Successfully implemented the add columns for the spreadsheet. Also made the add fields file more modular.