search

LocalGround / localground

Other
18 stars 7 forks source link

Ground overlays s3 #170

Closed gitriley closed 6 years ago

gitriley commented 6 years ago

Note: the refactoring we did to remove the "displayOverlay" attribute seems to have created a problem when dragging polygons and polylines. Now, when you drag a polygon/polyline, the vertices move, but the overlay itself remains in the same place until you finish dragging. This wasn't happening before.

vanwars commented 6 years ago

Good catch! I'll take a look.

On Feb 8, 2018 3:11 PM, "Riley Flynn" notifications@github.com wrote:

Note: the refactoring we did to remove the "displayOverlay" attribute seems to have created a problem when dragging polygons and polylines. Now, when you drag a polygon/polyline, the vertices move, but the overlay itself remains in the same place until you finish dragging. This wasn't happening before.

You can view, comment on, or merge this pull request online at:

https://github.com/LocalGround/localground/pull/170 Commit Summary

  • bug fixes in data-detail
  • Merge branch 'ground-overlays-s3' of https://github.com/ LocalGround/localground into ground-overlays-s3
  • fixed attach media bug
  • fix
  • sosme changes
  • now can add polygons
  • added polygons and polylines
  • small change
  • intentation error in view
  • reverted marker-style-view to what it was at commit 402b95a83c191f3600d273046a8f10837af93964
  • added edit and drag functionality to polygons and polylines
  • Debugging event discoordination for editing geometries
  • polys now save on edit
  • removing marker-level show/hide functionality
  • removed console.log statements

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LocalGround/localground/pull/170, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKGw_oLkFL03U8NL3k8vKpDgvch64xEks5tS38BgaJpZM4R_K_k .

gitriley commented 6 years ago

actually never mind. The problem seems to have began when I added the dragend-save functionality. I'll see if i can pinpoint what's causing it.

vanwars commented 6 years ago

OK! Keep me posted.

On Feb 8, 2018 3:48 PM, "Riley Flynn" notifications@github.com wrote:

actually never mind. The problem seems to have began when I added the dragend-save functionality. I'll see if i can pinpoint what's causing it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LocalGround/localground/pull/170#issuecomment-364287929, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKGw4Q4Cz687-NXrYJ6w9RrwqUicIK4ks5tS4fHgaJpZM4R_K_k .

gitriley commented 6 years ago

Fixed several bugs and now there is no latency when dragging shapes, and no duplication of event listeners (listeners are being properly cleared). Also, while I was there, I added the ability to delete vertices from a shape via a right click. We didn't discuss this, but it seems fairly necessary.

For deleting a vertex, we could also consider other user interactions. Options include: 1) a doubleclick, 2) create a little pop-up bubble above the selected vertex and provide a delete button.

Overall, though, I think the right click works well for now.