Closed gitriley closed 6 years ago
Great! I can take a look via the PR. Will take a look this afternoon.
On Mon, May 7, 2018 at 12:29 PM, Riley Flynn notifications@github.com wrote:
Creating the pull request now, but there are still some tests to finish.
I had trouble mocking a Record to be used in the tests for the DataDetailView. In particular, I couldn't find a way to properly attach a set of Fields to a Record.
You can view, comment on, or merge this pull request online at:
https://github.com/LocalGround/localground/pull/171 Commit Summary
- fixed symbol generation bug
- WIP: added some new form tests; cosmetic updates to Add Map form
- fixed small bugs when adding records
- Making changes to layer
- changes
- broke out DrawingManager and MouseMover into their own classes
- somethigng wrong with Record urlRoot. Take a look tomorrow
- Marker updates seem to be working again
- merged my branch into Rileys
- minor updates
- minor css edits
- reverting regressions
- got route working again
- updated naming conventions
- changes
- resolved conflicts
- began tests for drawing manager
- updates to drawing manager tests
- finished drawingManager tests
- some test updates
- added tests
File Changes
- M .vscode/settings.json https://github.com/LocalGround/localground/pull/171/files#diff-0 (14)
- M static/apps/main/templates/left/create-layer-form.html https://github.com/LocalGround/localground/pull/171/files#diff-1 (20)
- M static/apps/main/templates/left/symbol-item-view.html https://github.com/LocalGround/localground/pull/171/files#diff-2 (2)
- M static/apps/main/views/left/create-layer-form.js https://github.com/LocalGround/localground/pull/171/files#diff-3 (92)
- M static/apps/main/views/left/layer-list-child-view1.js https://github.com/LocalGround/localground/pull/171/files#diff-4 (143)
- M static/apps/main/views/left/layer-list-view.js https://github.com/LocalGround/localground/pull/171/files#diff-5 (8)
- M static/apps/main/views/left/new-map-modal-view.js https://github.com/LocalGround/localground/pull/171/files#diff-6 (8)
- M static/apps/main/views/left/symbol-collection-view.js https://github.com/LocalGround/localground/pull/171/files#diff-7 (25)
- M static/apps/main/views/left/symbol-item-view.js https://github.com/LocalGround/localground/pull/171/files#diff-8 (18)
- M static/apps/main/views/right/marker-style-view.js https://github.com/LocalGround/localground/pull/171/files#diff-9 (40)
- M static/css/main-new.css https://github.com/LocalGround/localground/pull/171/files#diff-10 (26)
- D static/css/main-new.css.map https://github.com/LocalGround/localground/pull/171/files#diff-11 (169)
- M static/css/scss/components/_layer_list_item.scss https://github.com/LocalGround/localground/pull/171/files#diff-12 (4)
- M static/css/scss/main-new.scss https://github.com/LocalGround/localground/pull/171/files#diff-13 (2)
- M static/css/scss/widgets/_form_controls.scss https://github.com/LocalGround/localground/pull/171/files#diff-14 (14)
- M static/lib/data/dataManager.js https://github.com/LocalGround/localground/pull/171/files#diff-15 (7)
- M static/lib/maps/basemap.js https://github.com/LocalGround/localground/pull/171/files#diff-16 (205)
- A static/lib/maps/controls/drawingManager.js https://github.com/LocalGround/localground/pull/171/files#diff-17 (178)
- A static/lib/maps/controls/mouseMover.js https://github.com/LocalGround/localground/pull/171/files#diff-18 (66)
- M static/models/record.js https://github.com/LocalGround/localground/pull/171/files#diff-19 (16)
- M static/tests/spec-helper1.js https://github.com/LocalGround/localground/pull/171/files#diff-20 (35)
- M static/tests/spec-runner1.js https://github.com/LocalGround/localground/pull/171/files#diff-21 (8)
- A static/tests/spec/lib/drawing-manager-test.js https://github.com/LocalGround/localground/pull/171/files#diff-22 (220)
- A static/tests/spec/lib/mouse-mover-test.js https://github.com/LocalGround/localground/pull/171/files#diff-23 (84)
- M static/tests/spec/views/main/create-layer-form-test.js https://github.com/LocalGround/localground/pull/171/files#diff-24 (31)
- A static/tests/spec/views/main/data-detail-test.js https://github.com/LocalGround/localground/pull/171/files#diff-25 (64)
- M static/tests/spec/views/main/layer-list-child-view-test.js https://github.com/LocalGround/localground/pull/171/files#diff-26 (86)
- M static/views/data-detail.js https://github.com/LocalGround/localground/pull/171/files#diff-27 (146)
Patch Links:
- https://github.com/LocalGround/localground/pull/171.patch
- https://github.com/LocalGround/localground/pull/171.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LocalGround/localground/pull/171, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKGw7LVJvTP9RaDtZsIwuRZ1U_LYkr9ks5twKCrgaJpZM4T1gp6 .
The PR's scope:
"Before you move onto anything new, I'd like you to make a separate branch that tests the AddNewMarker functionality. It needs the following:
Creating the pull request now, but there are still some tests to finish.
I had trouble mocking a Record to be used in the tests for the DataDetailView. In particular, I couldn't find a way to properly attach a set of Fields to a Record.