search

LocalGround / localground

Other
18 stars 7 forks source link

Feature newrecord tests #171

Closed gitriley closed 6 years ago

gitriley commented 6 years ago

Creating the pull request now, but there are still some tests to finish.

I had trouble mocking a Record to be used in the tests for the DataDetailView. In particular, I couldn't find a way to properly attach a set of Fields to a Record.

vanwars commented 6 years ago

Great! I can take a look via the PR. Will take a look this afternoon.

On Mon, May 7, 2018 at 12:29 PM, Riley Flynn notifications@github.com wrote:

Creating the pull request now, but there are still some tests to finish.

I had trouble mocking a Record to be used in the tests for the DataDetailView. In particular, I couldn't find a way to properly attach a set of Fields to a Record.

You can view, comment on, or merge this pull request online at:

https://github.com/LocalGround/localground/pull/171 Commit Summary

  • fixed symbol generation bug
  • WIP: added some new form tests; cosmetic updates to Add Map form
  • fixed small bugs when adding records
  • Making changes to layer
  • changes
  • broke out DrawingManager and MouseMover into their own classes
  • somethigng wrong with Record urlRoot. Take a look tomorrow
  • Marker updates seem to be working again
  • merged my branch into Rileys
  • minor updates
  • minor css edits
  • reverting regressions
  • got route working again
  • updated naming conventions
  • changes
  • resolved conflicts
  • began tests for drawing manager
  • updates to drawing manager tests
  • finished drawingManager tests
  • some test updates
  • added tests

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LocalGround/localground/pull/171, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKGw7LVJvTP9RaDtZsIwuRZ1U_LYkr9ks5twKCrgaJpZM4T1gp6 .

gitriley commented 6 years ago

The PR's scope:

"Before you move onto anything new, I'd like you to make a separate branch that tests the AddNewMarker functionality. It needs the following:

  1. Tests for the DrawingManager
  2. Tests for the MouseMover
  3. Tests for the new displayGeometryOptions functionality (it only displays for some of my layers but not all of them) in dataDetail.js and layerListChildView1.js
  4. Tests for the triggering of the DrawingManager dataDetail.js and layerListChildView1.js
  5. Tests for the receipt of the resulting geometry from the DrawingManager dataDetail.js and layerListChildView1.js"