search

LocalGround / localground

Other
18 stars 7 forks source link

Popovers #178

Closed vanwars closed 6 years ago

vanwars commented 6 years ago

Addresses Issues #177 and #176.

vanwars commented 6 years ago

@gitriley: This branch is ready for testing. Although a lot of files changed, this PR did the following:

  1. Created a generic popover class.
  2. Broke out html that appeared in popovers into their own classes
  3. Deprecated old popover functionality
  4. Wrote new tests

Can you take a look?

vanwars commented 6 years ago

Merged w/master. One Jasmine test is failing and needs to be resolved.