search

LocalGround / localground

Other
18 stars 7 forks source link

Feature fullscreen carousel #194

Closed gitriley closed 6 years ago

gitriley commented 6 years ago

This branch implements a fullscreen carousel. Merge this branch into master after merging 'bug_symbol-items' into master.

Click on an image in the photo carousel to open the fullscreen carousel.

screen shot 2018-06-14 at 7 03 31 pm

Note: This implementation also works with videos. However, there is one sort of bug. When you click on a video that is in the carousel (e.g. a youtube video), is simple starts the video, rather than opening the fullscreen carousel. I think that's pretty much what you'd expect, and probably not a problem, but I just wanted to note it here.

gitriley commented 6 years ago

Ok, great, thanks for taking a look at it. The carousel circles weren't overlapping on my external monitor, but I'm seeing it now from my laptop's screen. Will fix!

gitriley commented 6 years ago

I think if you recompile the scss then it will be fixed.

gitriley commented 6 years ago

Ok I just pushed again with the correct compiled main-new.css file. Not sure why it wasn't updated before...