Closed gitriley closed 6 years ago
Hi Riley,
Nice work. 2 thoughts:
CSS looks good! One minor suggestion: What do you think about changing the icons to fa-angle-right and fa-angle-down?
I have some questions about the showSymbolEditMenu feature for individual symbols. a) I made a few edits b/c the showSymbolEditMenu on the symbol-item-view.js wasn't getting called (symbol-collection-view.js's method was getting called instead), which was leading to confusion. However, now I'm noticing that the color picker isn't working for individual markers. Can you pull down and take a look? Thanks!
Sounds good to me! I was thinking about that exact thing today. I'll make the changes asap.
Ok, I'll take a look.
Not sure if you saw this question above: Should 'Individual' symbols also have the eye-icons for hide/show? I would think so, but I just want to confirm.
Changes in this PR:
Question: Should 'Individual' symbols also have the eye-icons for hide/show? I would think so, but I just want to confirm.