Closed gitriley closed 6 years ago
Hi Riley, This looks great! Two small requests:
One other problem that I'm aware of is that the routing that we use to select a particular marker doesn't work on the initial load of a page. So, for example, if you load a page fresh with the url 'http://localhost:7777/maps/c925f362d3574c14a910c70fbf1b3a72/#/layers/19/dataset_4/65', it won't actually display Record 65. The routing works when you click on the records after loading the page, but not on the initial load. I think this is due to the timing of the initialization of the legend from the presentation-app.js file; i.e. the legend isn't initialized until after the routing events are fired?
Ahh. Good catch. We can take a look at how routing is working on the map editor. Hopefully it's something small (maybe around the ordering of function calls on initialization?).
On Tue, Jul 10, 2018, 8:41 AM Riley Flynn notifications@github.com wrote:
- Sounds good. I was thinking the same thing actually.
- Ok. I'll fix this. Must be a problem with the rerendering.
One other problem that I'm aware of is that the routing that we use to select a particular marker doesn't work on the initial load of a page. So, for example, if you load a page fresh with the url ' http://localhost:7777/maps/c925f362d3574c14a910c70fbf1b3a72/#/layers/19/dataset_4/65', it won't actually display Record 65. The routing works when you click on the records after loading the page, but not on the initial load. I think this is due to the timing of the initialization of the legend from the presentation-app.js file; i.e. the legend isn't initialized until after the routing events are fired?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LocalGround/localground/pull/202#issuecomment-403869379, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKGwzBNA4ZIgDwZSVygQmBU9pMGKyo4ks5uFMsogaJpZM4VGLeE .
@gitriley, one more thing I found: if the layer is turned off in the Map Editor, that should be honored in the Map Presentation.
@gitriley Looks great! Last thing: can you please add presentation-app-test.js to the repo? I think you forgot to check it in.
@vanwars sorry about that! I just added it and pushed.
New functionality for presentation legend. Check to make sure layers and symbols are displaying correctly. e.g.:
example - uniform symbols:![screen shot 2018-07-06 at 6 24 45 pm](https://user-images.githubusercontent.com/20868615/42405404-fb03f5ce-8149-11e8-84fc-b213798acb0d.png)
example - symbols expanded:![screen shot 2018-07-06 at 6 24 18 pm](https://user-images.githubusercontent.com/20868615/42405405-fb2164b0-8149-11e8-98f6-7037565df75a.png)
example - symbols collapsed:![screen shot 2018-07-06 at 6 24 11 pm](https://user-images.githubusercontent.com/20868615/42405406-fb397ee2-8149-11e8-87fc-731b15b593f8.png)