Closed gitriley closed 6 years ago
Hey @gitriley, is this PR ready to be reviewed?
Yes, it's ready.
Well, I could add some tests for the save functions real quick.
Looks good! Will merge after Travis tests finish. Nice work.
OK! That would be great.
On Mon, Jul 23, 2018 at 2:51 PM Riley Flynn notifications@github.com wrote:
Well, I could add some tests for the save functions real quick.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LocalGround/localground/pull/211#issuecomment-407212888, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKGw1Vrkf3HTXbqH597Wmy_MtAcSMJnks5uJkVkgaJpZM4VZbfe .
@gitriley. Is this ready for review?
Yes!
👍
On Tue, Jul 24, 2018 at 4:23 PM Riley Flynn notifications@github.com wrote:
Yes!
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LocalGround/localground/pull/211#issuecomment-407583328, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKGw0ML-dNfjEP8leibUHWakkhMZBysks5uJ6xdgaJpZM4VZbfe .
Looks great, and I verified that the metadata flags are working with the DB. A few finishing touch requests: