LocalGround / localground

Other
18 stars 7 forks source link

Feature share settings menu #211

Closed gitriley closed 6 years ago

vanwars commented 6 years ago

Looks great, and I verified that the metadata flags are working with the DB. A few finishing touch requests:

  1. can you make the error message turn red when the password was entered incorrectly?
  2. In the sharing permissions form, in order to commit those changes to the database, just update the map model as follows:
    map.get('metadata').accessLevel = 3  // 1, 2, or 3
    map.set('password', 'my_password'); // retrieved from input form
    map.save()
vanwars commented 6 years ago

Hey @gitriley, is this PR ready to be reviewed?

gitriley commented 6 years ago

Yes, it's ready.

gitriley commented 6 years ago

Well, I could add some tests for the save functions real quick.

vanwars commented 6 years ago

Looks good! Will merge after Travis tests finish. Nice work.

vanwars commented 6 years ago

OK! That would be great.

On Mon, Jul 23, 2018 at 2:51 PM Riley Flynn notifications@github.com wrote:

Well, I could add some tests for the save functions real quick.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LocalGround/localground/pull/211#issuecomment-407212888, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKGw1Vrkf3HTXbqH597Wmy_MtAcSMJnks5uJkVkgaJpZM4VZbfe .

vanwars commented 6 years ago

@gitriley. Is this ready for review?

gitriley commented 6 years ago

Yes!

vanwars commented 6 years ago

👍

On Tue, Jul 24, 2018 at 4:23 PM Riley Flynn notifications@github.com wrote:

Yes!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LocalGround/localground/pull/211#issuecomment-407583328, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKGw0ML-dNfjEP8leibUHWakkhMZBysks5uJ6xdgaJpZM4VZbfe .