search

LocalGround / localground

Other
18 stars 7 forks source link

Title card display #223

Closed gitriley closed 5 years ago

gitriley commented 5 years ago

Made it so that if the map metadata attribute 'displayTitleCard' is false, then the title-card will not display in the Presentation App. If it is true, it will display the title card.

Also, now you can click on the map title in the top left section of the page and it will link you back to the title card, or to a "home" state if there is no title card.

Two issues:

  1. What happens if the user has 'displayTitleCard' set to true, but they haven't configured it with any information? Should we just show an empty title card? That seems reasonable to me, but I just want to make sure.

  2. I'm noticing a very strange bug where a title-card loses its references to media items that have been attached to it. It happens if you refresh the Main App and then toggle any of the presentation options. So map.get('metadata').titleCardInfo.media is an array with references to media items, and that array will get emptied unintentionally. Let me know if you need help recreating this bug. Might have something to do with the TitleCard model?

vanwars commented 5 years ago

@cynthiamah Looping in Cynthia:

What happens if the user has 'displayTitleCard' set to true, but they haven't configured it with any information? Should we just show an empty title card? That seems reasonable to me, but I just want to make sure.

Cynthia had a good idea to have the titleCard populated with default text by default (and even some instructions of how to modify the titleCard text). I like this idea, and I think it will help the user to understand a) what a title card is, and b) how to change it.

I'm noticing a very strange bug where a title-card loses its references to media items that have been attached to it. It happens if you refresh the Main App and then toggle any of the presentation options. So map.get('metadata').titleCardInfo.media is an array with references to media items, and that array will get emptied unintentionally. Let me know if you need help recreating this bug. Might have something to do with the TitleCard model?

I can take a look. I think I have a theory on this.