vanwars
commented
5 years ago @cynthiamah: I've deployed @gitriley's bugfixes to localground.org. Can you please test his changes? I've already done a first pass, but could use another set of eyes. Thanks!
This PR fixes bugs and issues described in issue #201 . Issues in bold, my comments in non-bold
Initial size for default marker - I think it should be a little larger because the teardrop shape is small at 20. 25 gives a decent teardrop marker and the circle and square are reasonably sized still. Changed default size to 25. Slightly difficult to determine where this was actually set, but I edited the Django models, and I think that was it.
Layer Properties uniform - If I create a layer using an existing dataset, the marker icon properties don't match default settings that marker icons were given when layer was created.
Layer Properties/Marker preview - the color of the icon updates but not the shape. Should be an accurate preview of current shape / color and size.
Layer Properties: The label Style: has the word "true" following it. Remove "true"
Layer Properties: Currently have to select the paintbrush to change the icon style. Can you make the both the paintbrush and the marker icon selectable? Also, add cursor:pointer (or hover effect).
Layer Properties: Color Ramp - if I select the down arrow icon, nothing happens. I have to select the color ramp. Can you make both the down arrow and the color ramp selectable?
Layer Properties: When I switch from Uniform to Individual (the very first time) it changes all the icons from current style to a new style (changed back to a circle of a different color). The first time Individual is selected, it should take the current properties of Uniform as the default settings. Use case: Uniform is the default. User sets up markers as desired, but then wants to make one item different. It has changed everything and I have to reset.
Sarah broke stroke color setting. Can you fix it?
Layer Properties: Opacity - change to percentage (i.e. 50% instead of .5)
Layer Properties: Uniform. If I select the pencil icon on the "All Items" category and update the icon properties, they are not reflected in the Layer Properties dialog. Uniform is an odd case where the All Items category icon properties and the Layer Properties icon properties should be coordinated.
[LOW] Layer Properties / Marker preview (also markers on the legend) - If I change the marker outline width, it properly updates the display on the map. The representation of the marker on the legend and in in the layer properties / preview area, are not the same as what is displayed on the map. The outline is much thinner than has been specified.