search

LocalGround / localground

Other
18 stars 7 forks source link

Final tasks #242

Closed gitriley closed 4 years ago

gitriley commented 5 years ago

Hey, this is the PR for all the final tasks. tasks:

  1. Date formatting - In the project detail app, we now have formatting for the maps. However, we do not yet have date formatting for the datasets because datasets don't have a date attribute yet.
  2. Improved error message when try to delete dataset attached to map

  3. 234 is complete.

  4. 231 is working now. My implementation differed from Cynthia's mockup slightly. E.g. I didn't think it made sense to have a dropdown menu (vs. a color picker) for color selection. I basically just moved the old panel_styles view over from our old style app (from like 1+ year ago) and updated where necessary.

    I kept the preview feature I had built. I think it's important when you're selecting text-color/background-color combinations, to be able to see an example of the two colors against each other, because a lot of color combinations actually make the text totally illegible. One alternative I considered was to have a text preview section to the right of the color and font pickers, since there's plenty of room for it.

vanwars commented 4 years ago

Hey @gitriley! Hope you're doing really well. Apologies for not merging this earlier...but I finally graduated and finally have time to revive this awesome project. Miss you and Cynthia and Sandbox Suites. Cheers!