search

Localight / LocalightWebService

Localism Clique Program
http://localism.github.io/LocalightDocs/#/
0 stars 0 forks source link

Wrong Icon - Fixed the mis-sync of occasion icons across the app #536

Closed torch2424 closed 8 years ago

torch2424 commented 8 years ago

closes #520 closes #533

As the title states, the occasion icon was actually out of sync due to arrays scattered across the app not synced with the occasion service. Now they all depend on the occasion service, and we have a singlar place to control occassions! Much better now! Please test this!

Example:

screenshot_2015-12-04-16-04-28

screenshot_2015-12-04-16-05-31

screenshot_2015-12-04-16-05-51

screenshot_2015-12-04-16-06-20

Simple Text change to "Holiday":

screenshot_2015-12-04-16-16-00

julianpoy commented 8 years ago

Please be very careful about committing the stripe live key. It is currently included in your commits, and is not something we publish in our repo. Please be more mindful about this in the future. In addition, did you change the order of any of the icons in the occasion service? If so, it will change the gift received text message. Please test the gift received SMS message to ensure your changes do not break that backend service.

torch2424 commented 8 years ago

Oh I just thought that was what we were doing, @julianpoy , you committed it a while ago https://github.com/Localism/LocalightWebService/commit/69aba8306f0a854467bd57a61e3fdb334d772bc4

I'll remove it in my newest branch

And I did not change the order of any icons in the occasion service.

Also, I did not change any information that is sent to the backend it is all the same info sent to it, and received by me.

torch2424 commented 8 years ago

And to be honest, I dont know how to get twilio working on my ngrok :hamburger:

julianpoy commented 8 years ago

Confirmed not a problem. You should really set up your server so it's connected to twilio and mail services.