search

Localight / LocalightWebService

Localism Clique Program
http://localism.github.io/LocalightDocs/#/
0 stars 0 forks source link

Clean Up the Branches #547

Closed torch2424 closed 8 years ago

torch2424 commented 8 years ago

Currently we have 8 branhes on this repo and most of which are dead. the current branches are:

production - @julianpoy errorHandler - myself triconPrintout - myself backgroundFix - myself localightCom - @julianpoy improvePanel - myself submitFix - @julianpoy

Out of my branch I can safely say that triconPrintout and backgroundFix are dead branches and can be deleted. Improve panel does have some stripe stuff that would be nice to keep.

@julianpoy I'd appreciate if you would delete any branches you do not need, and let me know which branches I can delete, unless you wanted me to keep any of these branches for some reason

julianpoy commented 8 years ago

I have removed most of my branches that are stale. Id like you to look at the formStyling branch and implement those changes manually in current code, and see how it looks. I believe it looked better at the time.

torch2424 commented 8 years ago

I do not see a form styling branch on our current branches I apologize, and I am deleting my branches now

torch2424 commented 8 years ago

Found it, and I shall try

julianpoy commented 8 years ago

Beware of deleting the oldStack. Although we don't reference it much, it is still good to have.

torch2424 commented 8 years ago

Oh yes definitely

julianpoy commented 8 years ago

Cool :+1:

torch2424 commented 8 years ago

@julianpoy Form styling literall only changes some placeholder text stuff, it literally just makes placeholder text grey and like slightly bigger. I feel like it wouldnt really do much or look much different at all

julianpoy commented 8 years ago

Yeah, that was what it did. And it really made a difference at the time, but its up to you! If you don't like it, just delete the branch.

torch2424 commented 8 years ago

I'm just going to delete the branch, black placeholder text was a @dwferrell request a while ago :) Thank you though! Closing this :haircut:

julianpoy commented 8 years ago

Ok. I wish you had taken a look though, it really did look better. Thanks for the cleanup!

torch2424 commented 8 years ago

Man I got the designers eye now, I can encode sass to visuals in my brain (joking)

but I actually did see it, placeholder text was gray in firefox for a while, it had like a stronger contrast with the black, but you're welcome :)