Switch application to Ionic

[julianpoy]

This is an issue for the switch of the Frontend to an Ionic app. Ionic will be generated with the following specific parameters:

Sass with Compass: Yes Plugins:

• device
• console
• keyboard
• splashscreen
• statusbar
• network-information
• device-orientation
• geolocation
• dialogs
• contacts

Template: Blank

[torch2424]

Perhaps we should make a new Repo for this? I feel like having another branch is quite odd

[julianpoy]

I think that keeping the same repo on a branch and using a new repo appear to be on somewhat equal levels before looking closely. Lets look closely: The reason I want to keep everything in this repo is because it pertains to the same project. We will maintain the same issue base, the same history base, and most importantly the same codebase.

If we were re-writing the app from the ground up, I think I would lean towards creating a new repo. Instead, we are just modifying the application shell. All of the views, controllers, services, etc, are going to be exactly the same. This is especially true because we are staying within Angular. Ionic isn't that great of a change. Perhaps it is even less of a change than MEANJS->AngularJS (and splitting the backend to its own repo) was.

Again, I think it is a reasonable thought to move to a new repo, and I understand your reasoning behind it. For this project, and for our move to Ionic, I do not feel a new repo is necessary or wanted. I think it will be much more productive to keep ourselves on this repo.

Github is about keeping track of history. In every repo, you will see code rewrites between versioning. This is why we create "releases". They help us map out the large differences between versions. For vX.0 in most repositories, it is a sign that a major code rewrite has taken place, often consisting of far greater changes that we are going to make.

I encourage you to think of a repo as a "project". Everything pertaining to that project should be stored under that repository. Remember, code is not our only thing stored in Github. All of our past releases and versioning takes place under one roof.

Changes like this are standard, and aren't something to be concerned about. This happens all of the time, and is almost always contained in the same version control container (whether that be CVS, SVN, Git, etc).

[julianpoy]

My goal with the comment above was to explain my thought process, and not to give you a blanket answer. I wanted to express my true response to your very valid suggestion. I hope this makes it more clear why I chose the direction I did. Cheers! :rabbit:

[torch2424]

Yeah I didnt think that deep into haha. But yeah I understand your essay and why you would write one haha! Then might I suggest we finish the last issues apparent in angular, and then create a release, then make another release once we test it working in Ionic? Or would you like to make an angular branch?

[julianpoy]

Just keep working on your current milestone. Don't worry about implementation of Ionic, it isn't on task right now.

[julianpoy]

This is now on the docket for discussion. We will be planning this out today.

[torch2424]

Folder Structure - Current Angular Folder Structure.

Functionality - Each view will stay approximately the same

Will be branched off f newest master

Ensure to make issues in backend for related changes, such as routes (Specifically text messages, and alerts, for things like the view giftcard page).

[torch2424]

in branch ionicSwitch

[torch2424]

We've Created a new repository for this, closing.

Localism/LocalightIonic: https://github.com/Localism/LocalightIonic