Update for PHP 8.0 feature set

rkeet commented 2 years ago

High guys,

Hop you don't mind this PR. Went to use this bundle and noticed that $locale was allowed to be null, which I found weird for a translation, so thought I'd create a PR for it. Then... Sort of ran with it for a few hours :)

Hope you like it, feel free to edit it.

Happy 2022.

Changes:

Updated PhpUnit config (from 6.5 to 9.3 (generated update)).
Set return types and function parameter types on all functions.
Removed docblocks not matching code.
Removed unnecessary docblocks. -> Left docblocks which might be annotations alone.
Changed setting locale to be required string (not allowing null).
Changed all provided properties of classes to be private (public getters and setters).
Updated PhpUnit tests to Php 8.0 features, this caused some required fixes in expectations (not using properties before instantiation and such).
Updated directory path of bundle loader to use platform independent directory separators.
Fixed invalid namespaces in some test classes.

paullla commented 2 years ago

Hi @rkeet thank you for the PRs and sorry for the waiting! Can you please rebase to the master? It will fix the CI problem.

rkeet commented 2 years ago

Hi, I decided to go a different route with my project, so no longer have this package setup in it.

Hopefully you can grab the PR and run with it, I won't be using it in the foreseeable future, and because of that don't really have the time to work on this.

Feel free to do whatever with this though :) free update ;-)

paullla commented 1 year ago

closing since https://github.com/Locastic/ApiPlatformTranslationBundle/pull/59 has the same changes. Thanks @rkeet

Locastic / ApiPlatformTranslationBundle

Update for PHP 8.0 feature set #49