search

Locastic / ApiPlatformTranslationBundle

Translation bundle for ApiPlatform based on Sylius translation
MIT License
85 stars 28 forks source link

Removal setting default translation #50

Closed rkeet closed 1 year ago

rkeet commented 2 years ago

Noticed that when doing a getTranslation call it would create a default Translation instance if no translation was available at the time of the get call.

As these are 2 separate commands (get vs create) decided to create a branch to remove the default creation of non-existent translations.

This PR is on top of PR https://github.com/Locastic/ApiPlatformTranslationBundle/pull/49.

rkeet commented 2 years ago

To view specific differences between PR 49 and this one, check out this branch to my own updated master PR here: https://github.com/rkeet/ApiPlatformTranslationBundle/pull/1/files

rkeet commented 2 years ago

Same as for https://github.com/Locastic/ApiPlatformTranslationBundle/pull/49: I won't be working on this / with this anymore in foreseeable future. Feel free to do whatever with it :)

paullla commented 1 year ago

closing